Draft
Conversation
View video Wrong if else Issue iframe Edit on the displayed video Small fixes Hide title, better button location Trying to hide title as showinfo no longer works Display video Reverted Music upload File input not declared Removed compressing on musics Issue uploading music Trying to display size & type Images not there Trying stuffs Trying with different object Reverted Added type, corrected filename Display differnt image if music Extra } Updated user storage used Issue in loop Management for music Set music from Library Test blo Audio player Wrong link Trying this Back to list Listing stuffs which are deleted Issue filtering Wrong path set Issue when adding a music to a quizz not being linked to it Wrong var used Debug Debug Debug Blo Debug Magic Reverted Fix in calculate hash I'm banana Remove storage path Calculate hash is bugged Blo Blo Debug Blo Blo Blo Blo Blo Blo Blo Blo Blo Blo Blo Blo Blo Blo Blo Log Log Blo Log Log Trying Save item Blo Blo Always delete button Delete button always showed Blo Banana Added player on admin Fix player UI fixes Removed hardcoded blocorp
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
# Conflicts: # classquiz/routers/editor.py
This reverts commit 4eab014.
This reverts commit 9d0350c.
This reverts commit 6a5ef05.
This reverts commit be128e1.
This reverts commit da83b9f.
This reverts commit 5c9f2e6.
This reverts commit cf74ae1.
This reverts commit e588779.
This reverts commit 307bb0c.
This reverts commit cc3f1a2.
This reverts commit 06dbd54.
This reverts commit 478e082.
This reverts commit 99d2d22.
for more information, see https://pre-commit.ci
… into feature/fixes-pr
Owner
|
Please don't create a PR depending on another one. It'll make it even more complex. I'll ignore this PR for now until we figure #401 out if that's fine for you |
# Conflicts: # .gitignore # classquiz/db/models.py # classquiz/routers/editor.py # frontend/pnpm-lock.yaml # frontend/src/lib/editor/uploader.svelte # frontend/src/lib/editor/uploader/Library.svelte # frontend/src/routes/edit/files/+page.svelte
# Conflicts: # classquiz/socket_server/__init__.py # frontend/src/lib/play/question.svelte # frontend/src/lib/play/results_kahoot.svelte
for more information, see https://pre-commit.ci
| {#each images as image} | ||
| <div class="rounded-sm border-2 border-[#B07156] p-2 flex-col flex gap-2"> | ||
| {#each files as file} | ||
| {#if file.mime_type === 'music/mp3'} |
Owner
There was a problem hiding this comment.
What about other file types than MP3? WAV maybe?
| import { get_foreground_color } from '$lib/helpers'; | ||
| import { kahoot_icons } from '$lib/play/kahoot_mode_assets/kahoot_icons'; | ||
| import CircularTimer from '$lib/play/circular_progress.svelte'; | ||
| import { QuizQuestionType } from '../../quiz_types'; |
Owner
There was a problem hiding this comment.
Please use absolute paths ($lib/)
| }); | ||
|
|
||
| const save_image_metadata = async () => { | ||
| const save_file_metadata = async () => { |
Owner
There was a problem hiding this comment.
Only needed for images alt-text, but fine for others, too
| <form class="flex flex-col" onsubmit={preventDefault(save_image_metadata)}> | ||
| <div class="w-auto h-auto m-auto rounded bg-white dark:bg-gray-700 p-4"> | ||
| <h1 class="text-2xl text-center">{$t('file_dashboard.edit_the_file')}</h1> | ||
| <form class="flex flex-col" on:submit|preventDefault={save_file_metadata}> |
Owner
There was a problem hiding this comment.
Suggested change
| <form class="flex flex-col" on:submit|preventDefault={save_file_metadata}> | |
| <form class="flex flex-col" onsubmit={prefentDefault(save_file_metadata)}> |
Svelte 5 changes
Owner
There was a problem hiding this comment.
I'd prefer an inline uploader. This has only been done for the videos, as ffmpeg in WASM would only load with these specific headers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Testing
Join a quiz and refresh twice the page. Previously, the second refresh would end up on the Quiz code input.