normal: make <c-o> always jump backward when snapshotting current selection#5446
Merged
mawww merged 1 commit intomawww:masterfrom Feb 19, 2026
Merged
normal: make <c-o> always jump backward when snapshotting current selection#5446mawww merged 1 commit intomawww:masterfrom
mawww merged 1 commit intomawww:masterfrom
Conversation
…ection JumpList::backward used to sometimes consume <c-o> without moving: when the current selection had diverged from the jump at m_current, we first pushed the current selection, then subtracted count. With count=1, this landed on the freshly pushed entry itself, so <c-o> behaved like "save checkpoint" instead of "jump backward". This was especially visible after going back into the middle of history, moving, then pressing <c-o> again: the first <c-o> could be a no-op from the user point of view. Fix by treating the implicit push as an extra internal step: if we push current before jumping, move back by count + 1. This keeps the "preserve current position for <c-i>" behavior, while making <c-o> consistently perform an actual backward jump. Add regression test: test/normal/jump/backward-dirty-middle Fixes mawww#5066
Owner
|
Thanks, this looks like a nice cleanup of that function on top of fixing the bug. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JumpList::backwardused to sometimes consume<c-o>without moving: when the current selection had diverged from the jump atm_current, we first pushed the current selection, then subtracted count.With
count=1, this landed on the freshly pushed entry itself, so<c-o>behaved like "save checkpoint" instead of "jump backward".This was especially visible after going back into the middle of history, moving, then pressing
<c-o>again: the first<c-o>could be a no-op from the user point of view.Fix by treating the implicit push as an extra internal step: if we push current before jumping, move back by
count + 1. This keeps the "preserve current position for<c-i>" behavior, while making<c-o>consistently perform an actual backward jump.Add regression test:
test/normal/jump/backward-dirty-middleFixes #5066