fix(client): refresh only if m_ui_pending is not empty#5453
Merged
mawww merged 1 commit intomawww:masterfrom Mar 5, 2026
Merged
fix(client): refresh only if m_ui_pending is not empty#5453mawww merged 1 commit intomawww:masterfrom
mawww merged 1 commit intomawww:masterfrom
Conversation
Fixes regression introduced in 551b20a where moving `generate_mode_line` after `update_display_buffer` removed the early return check. This caused `refresh` to be called even when no UI updates were needed, breaking tests that expected specific message sequences. Fixes: 551b20a Signed-Off-By: Paal Øye-Strømme <paal.o.eye@gmail.com>
Contributor
Author
|
@mawww I believe this one fixes 5405-error-face-on-empty-prompt regression test. I'm glad it is in place! Cheers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes regression introduced in 551b20a where moving
generate_mode_lineafterupdate_display_bufferremoved the early return check. This causedrefreshto be called even when no UI updates were needed, breaking tests that expected specific message sequences.Fixes: 551b20a