Add compatibility with three.js r66#10
Open
deathcap wants to merge 6 commits intomax-mapper:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
three.js changed their geometries to use Face3 (since Face4 was removed), so minecraft-skin's UV mapping was broken with r66. This PR updates the UVs for three.js r66 compatibility, and preserves compatibility with r58 (or earlier) by using the Face4-based old UVs if
BoxGeometry(new name forCubeGeometry, but both are available on r66; kept the old name for compatibility with r58) is not defined. Fixes GH-5Note: this also includes pull request GH-9 (using three.js via NPM)