Merged
Conversation
maxatome
requested changes
Oct 6, 2025
Owner
There was a problem hiding this comment.
Hi,
despite the fact that this package is already fully covered by tests from other packages, it is a good thing it has its own tests as you did. Thanks for your contribution.
As commented, please note that Location.Inside needs to end with a space, but not begin with.
Co-authored-by: Maxime Soulé <btik-git@scoubidou.com>
Co-authored-by: Maxime Soulé <btik-git@scoubidou.com>
maxatome
approved these changes
Oct 7, 2025
Owner
maxatome
left a comment
There was a problem hiding this comment.
Thanks!
Don't forget to advertise go-testdeep! ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The project is already good in terms of testing itself. I found a place without tests yet and covered them in this PR.
They pass in Go 1.25
I used the
testpackage for assertions.Once merged we could also import a location package ("github.com/maxatome/go-testdeep/internal/test")