Fix type of closing #172
Merged
Fix type of closing #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Entering the `contextlib.closing` context manager returns its argument, not an instance of `contextlib.closing` itself.
maxfischer2781
approved these changes
Mar 3, 2025
Owner
maxfischer2781
left a comment
maxfischer2781
left a comment
There was a problem hiding this comment.
Thanks for spotting this!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #172 +/- ##
=========================================
- Coverage 99.09% 0 -99.10%
=========================================
Files 20 0 -20
Lines 2097 0 -2097
Branches 556 0 -556
=========================================
- Hits 2078 0 -2078
+ Misses 11 0 -11
+ Partials 8 0 -8 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entering the
contextlib.closingcontext manager returns its argument, not an instance ofcontextlib.closingitself.