Open
Conversation
maxi-w
reviewed
Dec 12, 2024
Owner
maxi-w
left a comment
maxi-w
left a comment
There was a problem hiding this comment.
Hi,
thanks a lot for your contribution! I have two minor questions. I will try it out later and merge if everything works on my side.
Comment on lines
+75
to
+84
| def is_goal_completed(): | ||
| messages = [f"Goal: {goal}. Send <finish> if the goal is completed. Else explain why it is not completed."] | ||
| messages.append(computer.take_screenshot()) | ||
| response = client.models.generate_content( | ||
| model='gemini-2.0-flash-exp', contents=messages | ||
| ) | ||
|
|
||
| if "<screenshot>" in response.text: | ||
| print(response.text) | ||
| response_text = response.text | ||
| if "finish" in response_text: | ||
| return True, "Goal is completed." | ||
| return False, response_text |
Owner
There was a problem hiding this comment.
Did you see improvements with this double check for goal completion vs just asking for a tag?
Author
There was a problem hiding this comment.
Since the terminal is active, alt f is not worked. Even the goal completion also gave wrong results even with gemini-exp-1206. Should replace with a more powerful vision model.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1