chore: migrate app to Angular 8 #3
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,111 @@ | ||
| { | ||
| "$schema": "./node_modules/@angular/cli/lib/config/schema.json", | ||
| "version": 1, | ||
| "defaultProject": "compose-teams", | ||
| "cli": { | ||
| "packageManager": "yarn" | ||
| }, | ||
| "projects": { | ||
| "compose-teams": { | ||
| "root": "", | ||
| "sourceRoot": "src", | ||
| "projectType": "application", | ||
| "prefix": "app", | ||
| "schematics": {}, | ||
| "architect": { | ||
| "build": { | ||
| "builder": "@angular-devkit/build-angular:browser", | ||
| "options": { | ||
| "outputPath": "dist/compose-teams", | ||
| "index": "src/index.html", | ||
| "main": "src/main.ts", | ||
| "tsConfig": "src/tsconfig.app.json", | ||
| "polyfills": "src/polyfills.ts", | ||
| "assets": [ | ||
| "src/assets", | ||
| "src/favicon.ico", | ||
| { | ||
| "glob": "**/*", | ||
| "input": "node_modules/compose-teams/assets/", | ||
| "output": "./assets/" | ||
| } | ||
| ], | ||
| "styles": [ | ||
| "node_modules/material-design-icons-iconfont/dist/material-design-icons.css", | ||
| "src/styles.scss" | ||
| ], | ||
| "scripts": [] | ||
| }, | ||
| "polyfills": "src/polyfills.ts", | ||
| "optimization": false, | ||
| "outputHashing": "all", | ||
| "sourceMap": false, | ||
| "extractCss": true, | ||
| "namedChunks": false, | ||
| "aot": false, | ||
| "extractLicenses": false, | ||
| "vendorChunk": false, | ||
| "buildOptimizer": false, | ||
| "progress": true | ||
| }, | ||
| "serve": { | ||
| "builder": "@angular-devkit/build-angular:dev-server", | ||
| "options": { | ||
| "browserTarget": "compose-teams:build" | ||
| }, | ||
| "configurations": { | ||
| "production": { | ||
| "browserTarget": "compose-teams:build:production" | ||
| } | ||
| } | ||
| }, | ||
| "extract-i18n": { | ||
| "builder": "@angular-devkit/build-angular:extract-i18n", | ||
| "options": { | ||
| "browserTarget": "compose-teams:build" | ||
| } | ||
| }, | ||
| "test": { | ||
| "builder": "@angular-devkit/build-angular:karma", | ||
| "options": { | ||
| "main": "src/test.ts", | ||
| "karmaConfig": "src/karma.conf.js", | ||
| "polyfills": "src/polyfills.ts", | ||
| "tsConfig": "src/tsconfig.spec.json", | ||
| "scripts": [], | ||
| "styles": ["src/styles.scss"], | ||
| "assets": ["src/assets", "src/favicon.ico"] | ||
| } | ||
| }, | ||
| "lint": { | ||
| "builder": "@angular-devkit/build-angular:tslint", | ||
| "options": { | ||
| "tsConfig": ["src/tsconfig.app.json", "src/tsconfig.spec.json"], | ||
| "exclude": ["**/node_modules/**"] | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "compose-teams-e2e": { | ||
| "root": "e2e/", | ||
| "projectType": "application", | ||
| "architect": { | ||
| "e2e": { | ||
| "builder": "@angular-devkit/build-angular:protractor", | ||
| "options": { | ||
| "protractorConfig": "e2e/protractor.conf.js", | ||
| "webdriverUpdate": false, | ||
| "devServerTarget": "compose-teams:serve" | ||
| } | ||
| }, | ||
| "lint": { | ||
| "builder": "@angular-devkit/build-angular:tslint", | ||
| "options": { | ||
| "tsConfig": "e2e/tsconfig.e2e.json", | ||
| "exclude": ["**/node_modules/**"] | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| sudo: false | ||
|
|
||
| language: node_js | ||
| node_js: 10.15.2 | ||
|
|
||
| cache: yarn | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,8 +2,8 @@ a { | |
| text-transform: uppercase; | ||
| } | ||
|
|
||
| mat-sidenav-container { | ||
| mat-sidenav { | ||
| width: 350px; | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine removing lint-staged and the pre-commit hook.
But why have you removed prettier? The linting commands too?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maxime1992 Updated but as I say,
team.component.scssandneed-10-players.component.tsseems cause problem withPrettier. And I can't push without validation.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean that you haven't been able to push those files or that it will fail on CI?
Push them using --no-verify (from memory) and I'll take a look
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed with --no-verify.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maxime1992 Did you take a look for prettier?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really and to be honest I don't have much time for this project.
I think you should just work on your own fork =) !