Skip to content

Deprecate metro code #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
horgh merged 2 commits into from
Jan 13, 2025
Merged

Deprecate metro code #234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aba0367
Fix typo
oschwald Jan 13, 2025
ce3406e
Deprecate metro code
oschwald Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
CHANGELOG
=========

3.2.0
------------------

* `metroCode` on `GeoIp2\Record\Location` has been deprecated. The code
values are no longer being maintained.

3.1.0 (2024-11-15)
------------------

Expand All @@ -15,7 +21,7 @@ CHANGELOG
* IMPORTANT: PHP 8.1 or greater is now required.
* BREAKING: Read-only properties are now used for the model and record
classes rather than magic methods. This significantly improves performance.
* BREAKING: The `raw` property on model classess and the `record` property on
* BREAKING: The `raw` property on model classes and the `record` property on
record classes have been removed.
* BREAKING: On `GeoIp2\Record\Traits`, the deprecated `isAnonymousProxy` and
`isSatelliteProvider` properties have been removed.
Expand Down
8 changes: 4 additions & 4 deletions src/Record/Location.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,10 @@ class Location implements \JsonSerializable
public readonly ?float $longitude;

/**
* @var int|null The metro code of the location if the location
* is in the US. MaxMind returns the same metro codes as the
* Google AdWords API. See
* https://developers.google.com/adwords/api/docs/appendix/cities-DMAregions.
* @var int|null the metro code is a no-longer-maintained code for targeting
* advertisements in Google
*
* @deprecated
*/
public readonly ?int $metroCode;

Expand Down
Loading