Merged
Conversation
Member
oschwald
commented
Jan 22, 2025
oschwald
commented
- Join some split strings
- Whitespace improvements
- Replace raw attribute with to_dict method
- Make geoip2.mixins geoip2._internal
- Require record arguments to be keyword arguments
- Convert model classes to use keyword arguments
- Make ip_address property more similar to network
This makes it easier to maintain going forward.
Previously, it wasn't even always a string. This makes it consistent.
oschwald
force-pushed
the
greg/eng-1088-implement-minfraud-python-improvements-in-geoip2
branch
from
724e605 to
0e8790c
Compare
As requested by zizmor
horgh
requested changes
Jan 27, 2025
horgh
approved these changes
Jan 28, 2025
horgh
deleted the
greg/eng-1088-implement-minfraud-python-improvements-in-geoip2
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.