Add .NET 10 target and update LangVersion #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
oschwald
commented
Nov 19, 2025
oschwald
commented
- Add CLAUDE.md with codebase documentation
- Add .NET 10 target and update language version to C# 14
- Use collection expressions in test code
- Use primary constructors for attribute classes
- Simplify NetworkAttribute declaration
This file provides guidance to Claude Code when working with this repository, including development commands, architecture overview, and coding patterns specific to MaxMind-DB-Reader-dotnet. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
* Add net10.0 to all project target frameworks * Update LangVersion to 14.0 in all projects * Add .NET 10.0.x to GitHub Actions CI workflow * Update CLAUDE.md documentation to reflect new versions * Add release notes for version 4.3.0 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Convert array initializations to use collection expressions and
type inference where possible:
- Replace `new long[] { 24, 28, 32 }` with `new[] { 24, 28, 32 }`
(type inference) for `foreach` loops
- Replace `new byte[] { ... }` with `[...]` in test assertions
This modernizes test code to use more idiomatic C# syntax
without affecting performance or behavior.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Convert InjectAttribute and ParameterAttribute to use C# 14 primary constructor syntax. This reduces boilerplate code by: - Removing explicit constructor bodies - Moving parameter documentation to the type declaration - Making the code more concise and idiomatic The compiled IL remains the same, maintaining binary compatibility. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Remove unnecessary empty constructor from NetworkAttribute. The class has no parameters or state, so the constructor and body can be removed, resulting in a more concise declaration using C# 14 syntax. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
oschwald
force-pushed
the
greg/eng-3490
branch
from
74aae90 to
3485b36
Compare
- Update Microsoft.NET.Test.Sdk from 17.13.0 to 18.0.1 - Update xunit.v3 from 3.0.0 to 3.2.0 (now using xunit.v3.mtp-v2 for Microsoft Testing Platform v2) - Update xunit.runner.visualstudio from 3.1.0 to 3.1.5 - Update BenchmarkDotNet from 0.14.0 to 0.15.6 - Add EnableMSTestRunner property to support new testing platform 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
oschwald
force-pushed
the
greg/eng-3490
branch
from
3485b36 to
54a555f
Compare
horgh
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.