Fix PIE pre-packaged source implementation

Correct the PIE implementation based on testing:

- Use 'download-url-method' instead of 'source-method'
- Tarball naming: {extension-name}-v{version}.tgz (with 'v' prefix)
- Files must be at root level (no parent directories)
- Create tarball from within ext/ directory using 'tar * '

Verified working with PIE 1.2.1 - extension builds and installs successfully.

Author: oschwald

dev-bin/release.sh

@@ -177,14 +177,15 @@ $notes"
     # Create pre-packaged source tarball for PIE
     # PIE needs this because it doesn't handle git submodules automatically
     echo "Creating pre-packaged source tarball for PIE..."
-    pie_tarball="php_maxminddb-${version}-src.tgz"
+    pie_tarball="maxminddb-${tag}.tgz"
 
-    # Create tarball from the ext directory in the submodule
-    tar -czf "$pie_tarball" \
-        --transform "s|^MaxMind-DB-Reader-php/ext|php_maxminddb-${version}|" \
-        MaxMind-DB-Reader-php/ext/
+    # Create tarball with files at root level (PIE requirement)
+    # Note: naming must be {extension-name}-v{version}.tgz
+    pushd MaxMind-DB-Reader-php/ext > /dev/null
+    tar -czf "../../$pie_tarball" *
+    popd > /dev/null
 
-    if [ $? -ne 0 ]; then
+    if [ ! -f "$pie_tarball" ]; then
         echo "ERROR: Failed to create source tarball"
         popd > /dev/null
         exit 1

plan.md

@@ -7,9 +7,10 @@ Set up a new extension repository (`MaxMind-DB-Reader-php-ext`) that uses this r
 
 PIE downloads source code as ZIP archives from Composer/GitHub, which don't include git submodule contents. To work around this limitation, we use PIE's built-in support for **pre-packaged source archives**:
 
-- Set `"source-method": "pre-packaged-source"` in the `php-ext` section of composer.json
-- The release script creates a tarball: `php_maxminddb-{version}-src.tgz`
-- This tarball includes the full ext/ directory from the submodule
+- Set `"download-url-method": "pre-packaged-source"` in the `php-ext` section of composer.json
+- The release script creates a tarball: `maxminddb-v{version}.tgz`
+  - Naming must be: `{extension-name}-v{version}.tgz` (with the `v` prefix)
+  - Files must be at root level (no parent directories)
 - It's uploaded as a GitHub release asset
 - PIE automatically detects and uses this pre-packaged source instead of the ZIP archive
 
@@ -51,8 +52,7 @@ Initial files needed:
     "priority": 50,
     "support-zts": true,
     "support-nts": true,
-    "source-method": "pre-packaged-source",
-    "build-path": "MaxMind-DB-Reader-php/ext",
+    "download-url-method": "pre-packaged-source",
     "configure-options": [
       {
         "name": "with-maxminddb",
@@ -237,14 +237,15 @@ $notes"
     # Create pre-packaged source tarball for PIE
     # PIE needs this because it doesn't handle git submodules automatically
     echo "Creating pre-packaged source tarball for PIE..."
-    pie_tarball="php_maxminddb-${version}-src.tgz"
+    pie_tarball="maxminddb-${tag}.tgz"
 
-    # Create tarball from the ext directory in the submodule
-    tar -czf "$pie_tarball" \
-        --transform "s|^MaxMind-DB-Reader-php/ext|php_maxminddb-${version}|" \
-        MaxMind-DB-Reader-php/ext/
+    # Create tarball with files at root level (PIE requirement)
+    # Note: naming must be {extension-name}-v{version}.tgz
+    pushd MaxMind-DB-Reader-php/ext > /dev/null
+    tar -czf "../../$pie_tarball" *
+    popd > /dev/null
 
-    if [ $? -ne 0 ]; then
+    if [ ! -f "$pie_tarball" ]; then
         echo "ERROR: Failed to create source tarball"
         popd > /dev/null
         exit 1
@@ -306,7 +307,9 @@ echo "3. Announce release"
 - Ensures on main branch
 - Verifies tag checkout succeeds
 - Only commits if there are changes
-- Creates pre-packaged source tarball with naming convention: `php_maxminddb-{version}-src.tgz`
+- Creates pre-packaged source tarball with naming convention: `maxminddb-v{version}.tgz`
+  - Files at root level (no parent directories)
+  - Uses `{extension-name}-v{version}.tgz` pattern required by PIE
 - Uploads tarball as GitHub release asset for PIE
 - Cleans up tarball after upload
 - Handles push/release failures gracefully