Skip to content

Conversation

@oschwald
Copy link
Member

  • Ignore clangd conf file
  • Fix license config deprecation warnings
  • Correctly handle null check of entry_data_list

I suspect at some point, we were passing in `entry_data_list` as a
`MMDB_entry_data_list_s *`, which is what we do in other extensions, but
that was refactored to `MMDB_entry_data_list_s **` for reasons I do not
recall, and the loop check was never updated appropriately.

This never caused an actual issue as we also have the size check.
However, it could potentially lead to a segfault on a corrupt or
otherwise invalid database.
Previously, it wasn't using the right setuptools version. We have a
separate issue for switch our tox configuration over to tox-uv.
@horgh horgh merged commit e6e8398 into main May 5, 2025
75 checks passed
@horgh horgh deleted the greg/eng-1832 branch May 5, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants