Switch to ruff #204
Merged
Switch to ruff #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
oschwald
commented
May 16, 2025
oschwald
commented
- Switch to ruff for formatting
- Run ruff fix
- Run ruff unsafe fixes
- Add init.py file
- Improve typing
- Improve docs
- Minor style fixes and ignoring of particular lints
- Switch to ruff for linting
oschwald
force-pushed
the
greg/eng-1922
branch
3 times, most recently
from
448cdca to
8971b56
Compare
horgh
requested changes
May 22, 2025
Contributor
horgh
left a comment
horgh
left a comment
There was a problem hiding this comment.
Looks good! I have a couple questions.
horgh
requested changes
May 23, 2025
maxminddb/extension.pyi
Outdated
| def __enter__(self) -> Self: ... | ||
| def __exit__(self, *args) -> None: ... # noqa: ANN002 | ||
|
|
||
| # pylint: disable=too-few-public-methods |
Contributor
There was a problem hiding this comment.
Would we want to delete this pylint comment?
horgh
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.