Skip to content

update risk reasons in factory body example#1267

Merged
AndraMeer merged 3 commits intomainfrom
andram/update-factors-body-example
Feb 7, 2025
Merged

update risk reasons in factory body example#1267
AndraMeer merged 3 commits intomainfrom
andram/update-factors-body-example

Conversation

@AndraMeer
Copy link
Copy Markdown
Contributor

No description provided.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Feb 7, 2025

Deploying dev-site with  Cloudflare Pages  Cloudflare Pages

Latest commit: d7516b4
Status: ✅  Deploy successful!
Preview URL: https://f7957584.dev-site-4ua.pages.dev
Branch Preview URL: https://andram-update-factors-body-e.dev-site-4ua.pages.dev

View logs

@AndraMeer AndraMeer marked this pull request as ready for review February 7, 2025 19:07
Comment on lines +1592 to +1593
"reason": "The number of distinct Issuer ID Numbers found in the
velocity check on IP address raised the overall risk score"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is invalid JSON, that's why it is highlighted in red. There can't be a line break in the middle of a string. Is it possible to put it all on one line?

Suggested change
"reason": "The number of distinct Issuer ID Numbers found in the
velocity check on IP address raised the overall risk score"
"reason": "The number of distinct Issuer ID Numbers found in the velocity check on IP address raised the overall risk score"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I understand that this is for formatting/display purposes. The problem is that if a developer copies this into a tool or something expecting valid JSON, it won't work.

If y'all want it displayed in a particular format, scotty can probably achieve that with CSS. I can create a linear issue for that purpose.

Comment on lines +1602 to +1603
"reason": "The local time of day of the request raised the overall
risk score"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"reason": "The local time of day of the request raised the overall
risk score"
"reason": "The local time of day of the request raised the overall risk score"

Comment on lines +1612 to +1613
"reason": "The email domain being recently seen for the first time
in the minFraud network raised the overall risk score"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"reason": "The email domain being recently seen for the first time
in the minFraud network raised the overall risk score"
"reason": "The email domain being recently seen for the first time in the minFraud network raised the overall risk score"

Comment on lines +1622 to +1623
"reason": "minFraud network activity of the phone number lowered
the overall risk score"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"reason": "minFraud network activity of the phone number lowered
the overall risk score"
"reason": "minFraud network activity of the phone number lowered the overall risk score"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mm-jpoole i will put it on one line and resubmit. the line breaks are totally on me!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was that done to make it display in a certain way on the page? If so, feel free to create a linear issue and we can likely adjust the formatting via CSS.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it was and it was all me! i don't think this error is anywhere else so we're likely okay to leave as-is :) unless you want to get rid of the sideways scroll that exists now. I have no objection either way.

Copy link
Copy Markdown
Contributor

@mm-jpoole mm-jpoole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! Thanks 😄

@AndraMeer AndraMeer merged commit b7ead56 into main Feb 7, 2025
13 checks passed
@AndraMeer AndraMeer deleted the andram/update-factors-body-example branch February 7, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants