Merged
Conversation
Contributor
mm-kevcenteno
commented
Oct 15, 2025
mm-kevcenteno
commented
- Adds Lychee
- Fixes broken links
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Deploying dev-site with
|
| Latest commit: |
187b916
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1463fe88.dev-site-4ua.pages.dev |
| Branch Preview URL: | https://kevin-lychee.dev-site-4ua.pages.dev |
PatrickCroninMM
previously approved these changes
Oct 15, 2025
Contributor
PatrickCroninMM
left a comment
PatrickCroninMM
left a comment
There was a problem hiding this comment.
This looks great!
mm-kevcenteno
force-pushed
the
kevin/lychee
branch
from
18a831c to
187b916
Compare
PatrickCroninMM
approved these changes
Oct 16, 2025
Comment on lines
64
to
68
| - [Java](https://github.com/maxmind/minfraud-api-java/blob/main/src/main/java/com/maxmind/minfraud/request/Email.java#L414) | ||
| - [JavaScript](https://github.com/maxmind/minfraud-api-node/blob/main/src/request/email.ts#L313) | ||
| - [PHP](https://github.com/maxmind/minfraud-api-php/blob/main/src/MinFraud/Util.php#L284) | ||
| - [Python](https://github.com/maxmind/minfraud-api-python/blob/main/minfraud/request.py#L357) | ||
| - [Python](https://github.com/maxmind/minfraud-api-python/blob/main/src/minfraud/request.py#L375) | ||
| - [Ruby](https://github.com/maxmind/minfraud-api-ruby/blob/main/lib/minfraud/components/email.rb#L84) |
Contributor
There was a problem hiding this comment.
I feel like it's a little ambitious to think that we'll make sure these links are updated. It might be better to use permalinks for GitHub links instead of the current main. That being said, this is pre-existing, so not related to your PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.