Skip to content

Fix more minor issues#1534

Merged
oschwald merged 18 commits intomainfrom
wstorey/tweaks
Jan 13, 2026
Merged

Fix more minor issues#1534
oschwald merged 18 commits intomainfrom
wstorey/tweaks

Conversation

@horgh
Copy link
Contributor

@horgh horgh commented Jan 13, 2026

No description provided.

horgh and others added 11 commits January 12, 2026 19:38
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…tion

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 13, 2026

Deploying dev-site with  Cloudflare Pages  Cloudflare Pages

Latest commit: c982117
Status: ✅  Deploy successful!
Preview URL: https://d2c24db4.dev-site-4ua.pages.dev
Branch Preview URL: https://wstorey-tweaks.dev-site-4ua.pages.dev

View logs

horgh and others added 3 commits January 12, 2026 20:23
… responses documentation

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…sts documentation

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…tion

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Copy link
Member

@oschwald oschwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, a lot of good fixes!

{{</minfraud-schema-row>}}

{{< minfraud-schema-row key="session_age" type="request" valueType="decimal" valueTypeNote="min: 0, max: 10e13-1" >}}
{{< minfraud-schema-row key="session_age" type="request" valueType="decimal" valueTypeNote="min: 0, max: 1e14-1" >}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the correct value here is actually 1e13-1. This obviously was wrong before too.

{{< schema-table key="order" >}}

{{< minfraud-schema-row key="amount" type="request" valueType="decimal" valueTypeNote="min: 0, max: 1e141" >}}
{{< minfraud-schema-row key="amount" type="request" valueType="decimal" valueTypeNote="min: 0, max: 1e14-1" >}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this should also be 1e13-1, but I didn't double check.

{{</minfraud-schema-row>}}

{{< minfraud-schema-row key="quantity" type="request" valueType="integer" valueTypeNote="min: 0, max: 10e13-1" >}}
{{< minfraud-schema-row key="quantity" type="request" valueType="integer" valueTypeNote="min: 0, max: 1e14-1" >}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same.

{{</minfraud-schema-row>}}

{{< minfraud-schema-row key="price" type="request" valueType="Decimal" valueTypeNote="format: Decimal, min: 0, max: 1e14-1" >}}
{{< minfraud-schema-row key="price" type="request" valueType="decimal" valueTypeNote="min: 0, max: 1e14-1" >}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same.

| Code | Explanation |
| ---------------------------- | ------------------------------------------------------------------------------------------------------ |
| `ANONYMOUS_IP` | The IP address belongs to an anonymous network. See the object at/ip\_address/traits for more details. |
| `ANONYMOUS_IP` | The IP address belongs to an anonymous network. See the object at /ip\_address/traits for more details. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `ANONYMOUS_IP` | The IP address belongs to an anonymous network. See the object at /ip\_address/traits for more details. |
| `ANONYMOUS_IP` | The IP address belongs to an anonymous network. See the object at `/ip_address/traits` for more details. |


We provide a [Dispositions API](/minfraud/working-with-transaction-dispositions)
for use with Disposition setting from the Transaction Details page. Use this API
for use with disposition setting from the Transaction Details page. Use this API
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it matters much, but I suspect the capital D was intentional here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I wasn't sure about this one. I decided the old way was a bit odd and left it though. But I'll revert it.

horgh and others added 3 commits January 13, 2026 08:18
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The max input number is 1e13-1, not 1e14-1. This limit exists to
prevent credit card numbers from being accepted as numeric values.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@oschwald oschwald merged commit 7137a2a into main Jan 13, 2026
15 checks passed
@oschwald oschwald deleted the wstorey/tweaks branch January 13, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants