Skip to content

Conversation

@agdphd
Copy link
Contributor

@agdphd agdphd commented Jan 6, 2026

The Proto toolchain manager is pretty handy for managing tools like geoipupdate, and I'm currently considering it adopting it in a large monorepo at my job. Adding this YAML file to the repo makes it easy to integrate the tool.

If/once this is merged, I'll send a PR to the Moonrepo folks to add this to the Proto tool registry.

@horgh
Copy link
Contributor

horgh commented Jan 6, 2026

Thanks! I hadn't heard of Proto before.

I am not necessarily opposed to merging this. However I'm wondering if putting it in a repo like https://github.com/appthrust/proto-toml-plugins would make more sense. Glancing through the third party tools on the page you linked to, many seem to be in a Proto specific repo like that. What do you think? I'm mostly concerned about maintenance.

@agdphd
Copy link
Contributor Author

agdphd commented Jan 7, 2026

That could work, though I'm not personally affiliated with any such repo, so I'd need to either set one up or find one that accepts public contributions.

Thinking about maintenance, one advantage of having the config here is that it keeps it close to the source of truth for the download_file and archive_prefix schemas; if y'all ever change the structure of the release archives or version numbers, you could then also change the Proto config if you think of it or review a PR from a user who notices the problem.

@horgh horgh merged commit a4c72f2 into maxmind:main Jan 7, 2026
12 of 13 checks passed
@agdphd agdphd deleted the patch-1 branch January 8, 2026 15:44
agdphd added a commit to agdphd/proto that referenced this pull request Jan 8, 2026
`geoipupdate` is a tool to manage GeoIP2 and GeoLite database caches, which are used to geolocate IP addresses. I added a Proto plugin definition in maxmind/geoipupdate#453, so I'd like to add it to the public tool registry as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants