Use precious for linting in CI #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
horgh
force-pushed
the
wstorey/eng-3719-mmdbconvert-repo-runs-precious-in-github-actions-workflow
branch
from
ceffc29 to
9ce58f3
Compare
- Rename lint.yml to golangci-lint.yml for clarity - Add precious.yml to run precious for markdown formatting The golangci-lint action handles Go linting, while precious runs other configured linters (currently prettier for markdown). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
horgh
force-pushed
the
wstorey/eng-3719-mmdbconvert-repo-runs-precious-in-github-actions-workflow
branch
from
9ce58f3 to
2e1dc30
Compare
marselester
reviewed
Dec 30, 2025
| with: | ||
| persist-credentials: false | ||
|
|
||
| - uses: actions/setup-node@v4 |
Contributor
There was a problem hiding this comment.
BTW there is actions/setup-node@v6 https://github.com/actions/setup-node?tab=readme-ov-file#usage
ugexe
approved these changes
Dec 30, 2025
ugexe
left a comment
ugexe
left a comment
There was a problem hiding this comment.
LGTM, although I'll leave it to you to merge in case you want to address the comment from @marselester
Contributor
Author
|
Thanks! I'll just let dependabot update that so we don't have to re-review :-) |
horgh
deleted the
wstorey/eng-3719-mmdbconvert-repo-runs-precious-in-github-actions-workflow
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the standalone golangci-lint workflow with precious, which runs all configured linters (golangci-lint and prettier).
🤖 Generated with Claude Code