Refactor: Separate unsigned transaction building from initiate method#58
Open
Alex99y wants to merge 4 commits intomayan-finance:mainfrom
Open
Refactor: Separate unsigned transaction building from initiate method#58Alex99y wants to merge 4 commits intomayan-finance:mainfrom
Alex99y wants to merge 4 commits intomayan-finance:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change aims to provide a way to obtain unsigned transactions without passing a signer as an argument. Providing the unsigned transactions from a different function allows us to create the transactions in the backend to be sent to the frontend and be signed by the user.
Following the NTT Route interface, this function is named transfer and returns the unsigned transaction for an NTT transfer.
https://github.com/wormhole-foundation/native-token-transfers/blob/main/sdk/definitions/src/ntt.ts#L224