♻️ [#68] Migrate from setup.cfg to pyproject.toml#70
Open
danielmursa-dev wants to merge 6 commits intomainfrom
Open
♻️ [#68] Migrate from setup.cfg to pyproject.toml#70danielmursa-dev wants to merge 6 commits intomainfrom
setup.cfg to pyproject.toml#70danielmursa-dev wants to merge 6 commits intomainfrom
Conversation
danielmursa-dev
force-pushed
the
feature/68-migrate-setup.cfg
branch
from
12ea16d to
e0d9829
Compare
danielmursa-dev
changed the title
setup.cfg to pyproject.tomlsetup.cfg to pyproject.toml
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #70 +/- ##
===========================================
- Coverage 94.58% 83.38% -11.21%
===========================================
Files 47 22 -25
Lines 1201 614 -587
Branches 0 45 +45
===========================================
- Hits 1136 512 -624
- Misses 65 80 +15
- Partials 0 22 +22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
danielmursa-dev
force-pushed
the
feature/68-migrate-setup.cfg
branch
3 times, most recently
from
9ec0bb8 to
5d7d19a
Compare
danielmursa-dev
requested review from
OlhaZahoruiko and
stevenbal
and removed request for
stevenbal
stevenbal
requested changes
Feb 16, 2026
| @@ -1,15 +0,0 @@ | |||
| #!/usr/bin/env python | |||
Collaborator
There was a problem hiding this comment.
Is this no longer needed?
Contributor
Author
There was a problem hiding this comment.
Checked and maykin-common and also default-app they don't have this file anymore
This file is only needed for the two commands: generate_notificaties and register_kanalen, but these two commands should be run on the projects themselves, so each project already has this file, so I think you can delete it. I tried running these two commands in open-klant, by installing notifications-api-common locally, and it works well
danielmursa-dev
force-pushed
the
feature/68-migrate-setup.cfg
branch
2 times, most recently
from
502a23e to
cfc5a92
Compare
danielmursa-dev
force-pushed
the
feature/68-migrate-setup.cfg
branch
from
cfc5a92 to
453e5a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #68
Migrate from
setup.cfgtopyproject.toml