Skip to content

🔧 [#69] Add Pyright configuration#71

Open
OlhaZahoruiko wants to merge 5 commits intofeature/68-migrate-setup.cfgfrom
feature/69-Add-type-checking-with-pyright
Open

🔧 [#69] Add Pyright configuration#71
OlhaZahoruiko wants to merge 5 commits intofeature/68-migrate-setup.cfgfrom
feature/69-Add-type-checking-with-pyright

Conversation

@OlhaZahoruiko
Copy link
Contributor

@OlhaZahoruiko OlhaZahoruiko commented Feb 16, 2026

Closes #69

@OlhaZahoruiko OlhaZahoruiko force-pushed the feature/69-Add-type-checking-with-pyright branch 2 times, most recently from 44c073a to b8b8fb0 Compare February 16, 2026 15:53
@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2026

Codecov Report

❌ Patch coverage is 85.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.43%. Comparing base (5d7d19a) to head (fb24909).

Files with missing lines Patch % Lines
notifications_api_common/viewsets.py 50.00% 5 Missing ⚠️
notifications_api_common/kanalen.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@                       Coverage Diff                        @@
##           feature/68-migrate-setup.cfg      #71      +/-   ##
================================================================
+ Coverage                         83.38%   83.43%   +0.05%     
================================================================
  Files                                22       22              
  Lines                               614      628      +14     
  Branches                             45       45              
================================================================
+ Hits                                512      524      +12     
- Misses                               80       82       +2     
  Partials                             22       22              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@OlhaZahoruiko OlhaZahoruiko force-pushed the feature/69-Add-type-checking-with-pyright branch from 973502d to 764502a Compare February 16, 2026 16:13
@OlhaZahoruiko OlhaZahoruiko marked this pull request as ready for review February 16, 2026 16:15
@stevenbal stevenbal changed the base branch from main to feature/68-migrate-setup.cfg February 17, 2026 09:11
@OlhaZahoruiko OlhaZahoruiko force-pushed the feature/69-Add-type-checking-with-pyright branch from bb272bf to 4268aec Compare February 17, 2026 10:25
FORCE_COLOR: '1'


type-checking:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also run make sure the tests are run using tox and remove this job (similar to what I did in maykinmedia/open-api-framework#210)?

@OlhaZahoruiko OlhaZahoruiko force-pushed the feature/69-Add-type-checking-with-pyright branch from 0f2d124 to c921770 Compare February 17, 2026 15:13
@OlhaZahoruiko OlhaZahoruiko force-pushed the feature/69-Add-type-checking-with-pyright branch from dc62bb4 to fb24909 Compare February 17, 2026 17:10
@danielmursa-dev danielmursa-dev force-pushed the feature/68-migrate-setup.cfg branch 3 times, most recently from cfc5a92 to 453e5a9 Compare February 18, 2026 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add type checking with pyright

4 participants

Comments