Open
Conversation
Feels off to serialise the same data twice…
It's a read-only attribute; and also the front-end tab has no good way for showing an array of things.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #317 +/- ##
==========================================
+ Coverage 72.73% 72.94% +0.20%
==========================================
Files 159 159
Lines 4919 4919
Branches 472 472
==========================================
+ Hits 3578 3588 +10
+ Misses 1303 1293 -10
Partials 38 38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SilviaAmAm
reviewed
Oct 21, 2025
| ) | ||
| ], | ||
| "_expand.eigenschappen.statustype": statustype_options, | ||
| # feels a bit off to send the exact same options twice... |
There was a problem hiding this comment.
Slowly we are going to build a whole formio replacement with references and all 😄
| ], | ||
| "_expand.eigenschappen.statustype": statustype_options, | ||
| # feels a bit off to send the exact same options twice... | ||
| "_expand.zaakobjecttypen.statustype": statustype_options, |
There was a problem hiding this comment.
Should we expose the statustype dropdown since we don't have a way to manage (create/edit/delete) the statustypen?
|
|
||
| for (const field of fields) { | ||
| const fieldName = field.name.split(".").pop() as keyof TargetType; | ||
| // This downcast is not true! And it muddies the handling of |
Collaborator
There was a problem hiding this comment.
Correct, I think the downcast is necessary but should be keyof RelatedObject<TargetType>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't touch the issues with the date fields.
Can be closed if #265 gets removed instead of fixed.