Skip to content

✅ [#302] test: more wait_for in an attempt to reduce… #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svenvandescheur merged 2 commits into from
Nov 3, 2025
Merged

✅ [#302] test: more wait_for in an attempt to reduce… #332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47fcf47
:white_check_mark: [#302] test: more wait_for in an attempt to reduce…
svenvandescheur Oct 30, 2025
5aff50e
:ok_hand: [#302] test: only use wait_for_timeout when browser is webkit
svenvandescheur Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions backend/src/openbeheer/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@


@pytest.fixture
def runner(live_server_vcr) -> GherkinRunner:
return GherkinRunner(live_server_vcr)
def runner(live_server_vcr, browser) -> GherkinRunner:
return GherkinRunner(live_server_vcr, browser)


@pytest.fixture(scope="function")
Expand Down
10 changes: 8 additions & 2 deletions backend/src/openbeheer/utils/gherkin_e2e.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import re

from furl import furl
from playwright.sync_api import Locator, Page, expect
from playwright.sync_api import Browser, Locator, Page, expect
from pytest_django.live_server_helper import LiveServer
from zgw_consumers.constants import APITypes
from zgw_consumers.models import Service
Expand Down Expand Up @@ -59,8 +59,9 @@ def test_not_logged_in(page: Page, runner: GherkinRunner):
understand the test flow and the expected outcomes.
"""

def __init__(self, live_server: LiveServer):
def __init__(self, live_server: LiveServer, browser: Browser) -> None:
self.live_server = live_server
self.browser = browser

@property
def given(self):
Expand Down Expand Up @@ -176,6 +177,11 @@ def user_logs_out(self, page: Page) -> None:

logout_button = page.get_by_role("button", name="Logout")
logout_button.wait_for()

# ¯\_(ツ)_/¯ - Attempt to fix flakiness in WebKit
if self.runner.browser.browser_type.name == "webkit":
page.wait_for_timeout(120)

logout_button.click()

# Navigation
Expand Down
Loading