Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #345 +/- ##
==========================================
- Coverage 71.70% 71.10% -0.60%
==========================================
Files 164 166 +2
Lines 5213 5244 +31
Branches 542 544 +2
==========================================
- Hits 3738 3729 -9
- Misses 1436 1476 +40
Partials 39 39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CharString
left a comment
CharString
left a comment
There was a problem hiding this comment.
Looks good. Just a remark and a question out of my own ignorance.
There was a problem hiding this comment.
These cipher suites come from upstream?
I know, at least for TLS not JWT, Logius recently updated the allowed ciphers: https://gitdocumentatie.logius.nl/publicatie/dk/beveilig/2.0.1/#tls-ciphersuites
A quick search on the NCSC site did not yield me anything on cipher recommendations for JWT.
There was a problem hiding this comment.
Mhmm I don't know about this, I need to look into it 🤔
| except Service.DoesNotExist as exc: | ||
| raise ConfigurationRunFailed( | ||
| f"Could not find an existing `selectielijst` service with identifier `{model.selectielijst_service_identifier}`." | ||
| " Make sure it is already configured, manually or by first running the configuration step of `zgw_consumers`." |
There was a problem hiding this comment.
Does the order in settings.SETUP_CONFIGURATION_STEPS not enforce this? Or can steps be skipped?
4 participants
Fixes #343