Conversation
|
Not sure what to do with the besselnumba.py file. We now started to share that between timml and ttim. So should we give that its own repository? @dbrakenhoff, what do you think? |
|
Yea, I've been wondering about this question too. We also have plotting that is very similar between the two packages which could be shared, and there's probably more logic that could be used by both packages. Two options I think: we put all shared logic in one of the two and make that the dependency, or like you say, we create a new repository with stuff that's used in both. I'm a little more tempted to stuff all shared logic into one package, as that saves us the hassle of maintaining a third repository... but I'm not entirely sure yet either. |
|
I am afraid we have some version issues here. It seems dev is one commit behind master and this branch is based on dev. I am encountering notebooks that still use HeadLineSink type elements without calling them River (like the BuildingPit notebook). @dbrakenhoff can you see what is going on? At least dev should be fixed and then, if possible, this branch. |
If we put besselnumba in one of the two, it also a hassle. I don't expect there will be many changes once we make a separate besselnumba package. Other than updates to dependencies like numpy and numba. |
|
Fair enough, then we make a special bessel module, and other logic (e.g. plotting) is either repeated and/or borrowed from its neighbor. And I'll check what's going on with this PR and dev. |
|
I update dev from master, if we fix all the remaining naming issues here we should be good? |
2 participants
No description provided.