STM32H7: Fix wrong address for DTCM in linker script #346
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
I noticed that after #326, compilation is failing for STM32H7 targets! This turns out to be because:
NVIC_RAM_VECTOR_ADDRESSto find the start of DTCMNVIC_RAM_VECTOR_ADDRESSbased onMBED_RAM_START. This was not really the correct way to do it, as on MCUs with multiple RAM banks, it's hard to know what ram bank MBED_RAM_START actually refers toTo fix this, I updated the cmsis_nvic.h files to remove the no-longer-needed RAM definitions and to define
NVIC_RAM_VECTOR_ADDRESSin terms of the correctMBED_RAM_BANK_SRAM_DTC_STARTconstant.Impact of changes
Compilation fixed for STM32H743, and possibly other MCUs in this family.
Migration actions required
Documentation
None
Pull request type
Test results
STM32H743 compiles again!