Skip to content

Fix I2C slave test on STM32 #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 3, 2025
+41 −29
Merged

Fix I2C slave test on STM32 #455

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c035953
Start testing STM32U0 with test shield, make a few fixes
multiplemonomials Apr 24, 2025
c92c78e
Fix I2C slave not working on STM if you set the frequency after initi…
multiplemonomials May 1, 2025
cdceaf2
Add handling of a partial write by the master
multiplemonomials May 2, 2025
25a1864
Fix wording
multiplemonomials May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions targets/TARGET_STM/TARGET_STM32U0/stm_dma_info.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,10 @@

/// Mapping from SPI index to DMA link info for Tx
static const DMALinkInfo SPITxDMALinks[] = {
{1, 0, DMA_REQUEST_SPI1_TX},
{1, 2, DMA_REQUEST_SPI2_TX},
{1, 2, DMA_REQUEST_SPI1_TX},
{1, 4, DMA_REQUEST_SPI2_TX},
#if defined (SPI3)
{1, 4, DMA_REQUEST_SPI3_TX}
{1, 6, DMA_REQUEST_SPI3_TX}
#endif
};

Expand Down
4 changes: 2 additions & 2 deletions targets/TARGET_STM/i2c_api.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1120,11 +1120,11 @@ int i2c_byte_read(i2c_t *obj, int last)
if (last) {
/* Disable Address Acknowledge */
tmpreg = tmpreg & (~I2C_CR2_RELOAD);
tmpreg |= I2C_CR2_NACK | (I2C_CR2_NBYTES & (1 << 16));
tmpreg |= I2C_CR2_NACK | (1 << I2C_CR2_NBYTES_Pos);
} else {
/* Enable reload mode as we don't know how many bytes will be sent */
/* and set transfer size to 1 */
tmpreg |= I2C_CR2_RELOAD | (I2C_CR2_NBYTES & (1 << 16));
tmpreg |= I2C_CR2_RELOAD | (1 << I2C_CR2_NBYTES_Pos);
}

/* Set the prepared configuration */
Expand Down
4 changes: 0 additions & 4 deletions targets/targets.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4803,10 +4803,6 @@ mode is recommended for target MCUs with small amounts of flash and RAM.",
"TRNG",
//"USBDEVICE" // TODO
],
"device_has_remove": [
"I2C", // Not tested just prepared
"I2CSLAVE" // Not tested just prepared
],
"is_mcu_family_target": true
},
"MCU_STM32U083xC": {
Expand Down