Apollo3: Simplify and standardize pin modes #485
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This PR simplifies and standardizes the PinMode enum on Apollo3. Previously, this enum contained every possible pin setting it was possible to set on the device, even ones that didn't really make sense (e.g. disabling the input so it reads as 0). Now, this enum is much simpler and only contains pin modes that are (semi-)standard across other Mbed targets.
I also fixed an issue where if a pin was configured as an open-drain output, reading it would always return the written state of the pin instead of its actual electrical state.
Impact of changes
Migration actions required
Documentation
I'll add a note to the docs site about how only IO_20 has a pulldown.
Pull request type
Test results
Verified that Apollo3 now passes the GPIO test, except that the pull-down test fails as it does not support this.