-
Notifications
You must be signed in to change notification settings - Fork 26
Add new target: DISCO_STM32H573I (STM32H573I-DK) #491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
add OCTOSPI Flash (to be tested)
fix init-deinit-init sequence of OSPIFBlockDevice by performing a soft reset at deinit
fix style check errors
fix astyle errors
targets/TARGET_STM/TARGET_STM32H5/TARGET_STM32H573xI/TOOLCHAIN_GCC_ARM/STM32H573xI.ld
Show resolved
Hide resolved
Would be cool to hold the content of PR around its original idea. The name of PR is about add a STM32H5 dev board but inside is a lot of fixes for DMA and XSPI. The 'usb-device-basic' is failing with every STM32 target and usually it was caused by a Endpoint Abort part, if I remember. |
No other STM32 board has actually used XSPI yet. I'm adding it here mainly to provide a complete featureset for this new target, while not breaking existing boards. |
Ah, ok, my bad. I did the GT test of USBHID with Nucleo-H563ZI and it pass - #437 (comment) |
I have already installed hidapi 0.14.0.post2, so that is not the issue. The error message of the USB HID test is:
For the USB basic test, the error message is:
Both of these errors are related to pyusb. |
My setup is
|
targets/TARGET_STM/TARGET_STM32H5/TARGET_STM32H573xI/cmsis_nvic.h
Outdated
Show resolved
Hide resolved
targets/TARGET_STM/TARGET_STM32H5/TARGET_STM32H573xI/cmsis_nvic.h
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK reviewed the first half of the change (up through USBPhy_STM32.cpp)!
connectivity/drivers/emac/TARGET_STM/TARGET_STM32H5/TARGET_DISCO_H573I/stm32h5_eth_init.c
Outdated
Show resolved
Hide resolved
storage/blockdevice/COMPONENT_OSPIF/include/OSPIF/OSPIFBlockDevice.h
Outdated
Show resolved
Hide resolved
storage/blockdevice/COMPONENT_OSPIF/include/OSPIF/OSPIFBlockDevice.h
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still reviewing, not done yet but more comments!
targets/TARGET_STM/TARGET_STM32H5/TARGET_STM32H573xI/TOOLCHAIN_GCC_ARM/STM32H573xI.ld
Show resolved
Hide resolved
moved all linker scripts of STM32H5 to the linker_scripts folder fixed issues found in the review
targets/TARGET_STM/TARGET_STM32H5/linker_scripts/STM32H503_FAMILY/CMakeLists.txt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on this! Looks good, just a few last tiny things.
Summary of changes
This PR adds new target DISCO_STM32H573I (STM32H573I-DK) and the following features for the STM32H5 family:
QSPI with DMA (read speed increased from 4MB/s without DMA to 39MB/s with [email protected])
OSPI with DMA (read speed increased from 4MB/s without DMA to 60MB/s with [email protected])
USB
Impact of changes
Mbed CE now officially supports DISCO_STM32H573I (STM32H573I-DK).
QSPI, OSPI and USB features for the STM32H5 family are enabled.
OSPI DMA is also enabled and tested on B-U585I-IOT02A and STM32L4R9I-DISCO.
Migration actions required
Documentation
No documentation at the moment.
Pull request type
Test results
greentea-log-h573.txt
The following tests FAILED:
21 - test-mbed-usb-device-basic (Failed)
22 - test-mbed-usb-device-hid (Failed)
101 - test-mbed-connectivity-netsocket-nanostack-dns (Failed)
104 - test-mbed-connectivity-netsocket-nanostack-tcp (Failed)
105 - test-mbed-connectivity-netsocket-lwipstack-tls (Failed)
106 - test-mbed-connectivity-netsocket-nanostack-tls (Failed)
108 - test-mbed-connectivity-netsocket-nanostack-udp (Failed)
109 - test-mbed-connectivity-network-emac (Failed)
111 - test-mbed-connectivity-netsocket-nanostack-network-interface (Failed)
Apart from the tests related to netsocket, I'm unable to pass 'usb-device-basic' and 'usb-device-hid' tests. On boards known to have good USB support, such as NUCLEO-F413ZH, these tests also failed. Maybe these tests require a specific version of libusb to be installed?