Skip to content

Conversation

multiplemonomials
Copy link
Collaborator

@multiplemonomials multiplemonomials commented Sep 10, 2025

Summary of changes

The intention of this CMake script was to install cysecuretools only if needed. However, I missed the fact that the block of code I added always gets executed because the script always gets included regardless of target. This PR moves the python package to be installed inside the function that creates the post build function, ensuring that it will only be installed for the specific Cypress targets that need it.

This is an important fix because cysecuretools currently fails to install on Python 3.13 on Macs and Arm Linux.

Impact of changes

Migration actions required

Documentation

none


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

@multiplemonomials multiplemonomials merged commit 6f234c6 into master Sep 11, 2025
53 checks passed
@multiplemonomials multiplemonomials deleted the bugfix/fix-cysecuretools-always-installed branch September 11, 2025 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants