Skip to content

Conversation

@niehues-itemis
Copy link
Collaborator

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements SPDX license expression support in the Maven POM by replacing the hardcoded Apache-2.0 license with a dynamic license mapping system that reads license information from MPS's third-party-libraries.json file.

Key changes:

  • Adds spdx-license-mapping plugin (version 1.0.1) from itemis cloud repository to handle SPDX license format conversion
  • Replaces static license definition with dynamic license extraction from license/third-party-libraries.json within the downloaded MPS distribution
  • Ensures POM generation tasks depend on unzipMPS to guarantee license file availability

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
settings.gradle Adds pluginManagement configuration to resolve the custom spdx-license-mapping plugin from itemis cloud repository
build.gradle Integrates SPDX license plugin, replaces hardcoded license with dynamic JSON-based license mapping, and ensures task dependencies for POM generation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sergej-koscejev
Copy link
Member

Where can I see the sources of spdx-license-mapping plugin? Also, I have tried browsing the gradle-plugins repository but it seems it's not browsable, although the plugin can be downloaded.

Shouldn't the plugin have a fully qualified ID? e.g. com.itemis.spdx-license-mapping?

@stephaneberle9 stephaneberle9 merged commit b744660 into mbeddr:master Jan 15, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide an SPDX license expression in the POM

3 participants