Skip to content

execute-generators: do not collect occurred errors #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wsafonov merged 1 commit into from
Sep 10, 2025
Merged

execute-generators: do not collect occurred errors #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions execute-generators/src/main/kotlin/de/itemis/mps/gradle/generate/Helper.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,14 @@ val logger = logging.getLogger("de.itemis.mps.gradle.generate")

private class MsgHandler : IMessageHandler {
val logger = logging.getLogger("de.itemis.mps.gradle.generate.messages")
val errors = mutableListOf<IMessage>()
// explicitly store error occurrence, since MPS generation IResult is not reliable enough (might be successful despite errors)
var errorOccurred = false
override fun handle(msg: IMessage) {
when (msg.kind) {
MessageKind.INFORMATION -> logger.info(msg.text, msg.exception)
MessageKind.WARNING -> logger.warn(msg.text, msg.exception)
MessageKind.ERROR -> {
errors.add(msg)
errorOccurred = true
logger.error(msg.text, msg.exception)
}
null -> logger.error(msg.text, msg.exception)
Expand Down Expand Up @@ -187,11 +188,11 @@ private fun makeModels(proj: Project, models: List<SModel>): GenerationResult {
val result = future.get()
logger.info("generation finished")
return when {
result.isSucessful && msgHandler.errors.isEmpty() -> {
result.isSucessful && !msgHandler.errorOccurred -> {
logger.info("generation result: successful")
GenerationResult.Success
}
result.isSucessful && msgHandler.errors.isNotEmpty() -> {
result.isSucessful && msgHandler.errorOccurred -> {
logger.error("generation result: successful, but errors were reported")
GenerationResult.Error
}
Expand Down
Loading