Merged
Conversation
… be referenced in `multiphase_sources` framework
…lip Velocity Model`, `Gravity Source`, `Artificial Phase Compression`, `Continuum Surface Force` (surface tension source)
…, `Perfect Gas EoS`, `Peng-Robinson EoS`, `Helmholtz-Energy EoS`, `Const Viscosity`, `Sutherland's Viscosity Model`, `Andrade Viscosity Correlation`.
- Involves testing `gravity` effects via water column collapse scenario. - Also tests such fluid models as `Perfect Gas`, `Andrade's Correlation`, `Sutherland's Law`
…`p_rgh` formulation. - Hides untested sources.
- Added documentation.
…energy model. - Irrelevant code was removed.
…nstantScalar` value for temperature field.
added 17 commits
February 18, 2026 06:31
…' into AA/adaptive-time-stepping
…sed inside Runtime())
mberto79
requested changes
Feb 25, 2026
Owner
mberto79
left a comment
There was a problem hiding this comment.
@egyaa20 just added a few minor comments, the main change is to make modification to ensure this PR is GPU compatible. To allow this, I have left comment through the code, in addition, we need a new constructor for the Configuration type (in the file simulate_0_types.jl. Where we define the struct as:
@kwdef struct Configuration{SC,SL,RT,HW,BC,PP}
schemes::SC
solvers::SL
runtime::RT
hardware::HW
boundaries::BC
postprocess::PP = nothing
end
Adapt.@adapt_structure ConfigurationWe need to remove the default keyword constructor that's created with the @kwdef macro i.e.:
struct Configuration{SC,SL,RT,HW,BC,PP}
schemes::SC
solvers::SL
runtime::RT
hardware::HW
boundaries::BC
postprocess::PP
end
Adapt.@adapt_structure ConfigurationWithin a new custom constructor definition we will need to move the runtime object to the GPU so it can be accessed within kernels, it would look something like:
Configuration(; schemes, solvers, runtime, hardware, boundaries, postprocess=nothing) = begin
Configuration(
schemes=schemes,
solvers=solvers,
hardware=hardware,
boundaries=boundaries,
postprocess=postprocess,
runtime=adapt(hardware.backend, runtime)
)
endThat should do it (although please check I didn't run the pseudo code above 🫤 )
Once we confirm GPU compitibility, I think this is ready to merge! Thanks!
added 7 commits
February 26, 2026 06:11
…cessed by all solvers
mberto79
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add optional adaptive time-stepping via a new (optional)
AdaptiveTimeSteppingconfiguration block insideRuntime, ensuring compatability with other solvers and test cases. Time-step updates are handled through multiple dispatchupdate_dt!function to avoid if statements when adaptative stepping is turned on/off.