Improve accuracy + allow mpfr::mpreal and boost's float128#78
Open
cffk wants to merge 1 commit intomborgerding:masterfrom
Open
Improve accuracy + allow mpfr::mpreal and boost's float128#78cffk wants to merge 1 commit intomborgerding:masterfrom
cffk wants to merge 1 commit intomborgerding:masterfrom
Conversation
(1) Accuracy has been improved in the set up of the _twiddles array. Now sin and cos are only evaluated for angles in [-pi/4, pi/4] and all the elementary symmetries of the trig functions are preserved. This reduces the round-off error to be competitve with fftw. (2) A key advantage of kissfft over fftw is that it can be used with non-standard floating point numbers, e.g., mpfr::mpreal and boost::multiprecision::float128. For this to "work", the math functions need to be called without the "std::" prefix to allow the specific overloads for these functions to be found. "using" clauses are added to the code so that the standard functions are still found for the standard floating point types.
cffk
added a commit
to geographiclib/geographiclib
that referenced
this pull request
Jun 4, 2022
AreaEst computes the order of the DST needed for accurate computation of the area integral. kissfft.hh is from https://github.com/mborgerding/kissfft with PR mborgerding/kissfft#78 applied.
|
An interesting change; I'd like it's being double-checked and merged. It seems though this repository is no longer maintained... it waits for someone to take it over and go on with KissFFTv2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(1) Accuracy has been improved in the set up of the _twiddles array.
Now sin and cos are only evaluated for angles in [-pi/4, pi/4] and all
the elementary symmetries of the trig functions are preserved. This
reduces the round-off error to be competitve with fftw.
(2) A key advantage of kissfft over fftw is that it can be used with
non-standard floating point numbers, e.g., mpfr::mpreal and
boost::multiprecision::float128. For this to "work", the math functions
need to be called without the "std::" prefix to allow the specific
overloads for these functions to be found. "using" clauses are added to
the code so that the standard functions are still found for the standard
floating point types.