kissfft library is implemented only in C#90
Open
bkuhls wants to merge 1 commit intomborgerding:masterfrom
Open
kissfft library is implemented only in C#90bkuhls wants to merge 1 commit intomborgerding:masterfrom
bkuhls wants to merge 1 commit intomborgerding:masterfrom
Conversation
By default, CMake assumes that the project is using both C and C++. By explicitly passing 'C' as argument of the project() macro, we tell CMake that only C is used, which prevents CMake from checking if a C++ compiler exists. Enable CXX for tests only for testcpp.cc.
Collaborator
|
Am not well versed in build systems, but shouldn't the C++ enable be guarded?
https://cmake.org/cmake/help/latest/variable/BUILD_TESTING.html if(BUILD_TESTING)
enable_language(CXX)
endif()Or is that just not relevant/needed at all here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, CMake assumes that the project is using both C and C++. By explicitly passing 'C' as argument of the project() macro, we tell CMake that only C is used, which prevents CMake from checking if a C++ compiler exists.
Enable CXX for tests only for testcpp.cc.