fix: Load selected trip shapes on trip details #1523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmmaSimon
force-pushed
the
es-trip-route-shape-disappearing
branch
from
cc989cc to
75267b2
Compare
EmmaSimon
force-pushed
the
es-trip-route-shape-disappearing
branch
from
75267b2 to
ed7ac01
Compare
boringcactus
approved these changes
Feb 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: Trip details route shape bug
Requires mbta/mobile_app_backend#415 to be deployed to the prod backend
Instead of using the same route shapes on the map that were present on the stop details page when you open trip details, this specifically loads the selected trip's shape. This also helps with branching and uncommon patterns, instead of showing all possible routes on trip details, now it will only show the route for the selected trip.
iOS
- [ ] If you added any user-facing strings on iOS, are they included in Localizable.xcstrings?- [ ] Add temporary machine translations, marked "Needs Review"android
- [ ] All user-facing strings added to strings resource in alphabetical order- [ ] Expensive calculations are run inwithContext(Dispatchers.Default)where possible (ideally in shared code)Testing
Fixed broken tests and added a unit test for updated map VM behavior, verified that the behavior works as expected on both iOS and Android connected to a local backend