fix(iOS): Upgrade CustomAlert dependency #1552
Merged
+40
−121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmmaSimon
force-pushed
the
es-notification-favorites-save-bug
branch
from
5aa3033 to
dedf250
Compare
This was not behaving properly on iOS 26, it now works properly and has liquid glass styling.
Due to changes to the CustomAlert library, it's now no longer possible to put the buttons into a separate View. And since the CustomAlert has no mechanism for testing, and isn't compatible with ViewInspector, we now have no way to unit test the button behavior.
EmmaSimon
force-pushed
the
es-notification-favorites-save-bug
branch
from
dedf250 to
74e9e86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: Fix: can't add favorites at stations with notifications disabled
The CustomAlert library we use wasn't working properly in iOS 26, this upgrades it, which resolves the issues and updates the styling to match the system (the styling still uses the classic style on older iOS versions).
iOS
- [ ] If you added any user-facing strings on iOS, are they included in Localizable.xcstrings?- [ ] Add temporary machine translations, marked "Needs Review"Testing
Manually verified that the alerts save properly on iOS 26.
Due to changes to the CustomAlert library, it's now no longer possible to put the buttons into a separate View. And since the CustomAlert has no mechanism for testing, and isn't compatible with ViewInspector, we now have no way to unit test some basic button behavior we were previously testing.