Merged
Conversation
digitalcora
approved these changes
Dec 5, 2025
Contributor
digitalcora
left a comment
digitalcora
left a comment
There was a problem hiding this comment.
Would it be straightforward to add test coverage for this? Otherwise looks good.
Collaborator
Author
|
This module doesn't have a test harness, so unfortunately it wouldn't be straightforward. It's on my list to build out though, since this logic has gotten more intricate over time. I did do an end-to-end test of this change locally to verify it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
This is part of a fix for an issue with PA messages containing reserved XML characters. Escapes all special characters before sending the payload to Watts/Polly.