Remove Opts and include_schedules from Departures Query config#71
Merged
robbie-sundstrom merged 1 commit intomainfrom Nov 5, 2025
Merged
Remove Opts and include_schedules from Departures Query config#71robbie-sundstrom merged 1 commit intomainfrom
Opts and include_schedules from Departures Query config#71robbie-sundstrom merged 1 commit intomainfrom
Conversation
robbie-sundstrom
changed the title
Opts and include_schedules from Departures Query config
deanshi
approved these changes
Nov 5, 2025
| @@ -1,16 +0,0 @@ | |||
| defmodule ScreensConfig.Departures.Query.Opts do | |||
Contributor
There was a problem hiding this comment.
Nice 🎆
Is this the opts that matches the opts type in departure.ex? Does this mean that we could in the future clean up all of the opts usage within departure.ex?
Contributor
Author
There was a problem hiding this comment.
No that's a different opts that includes the now time for testing purposes. I also added an additional field to that opts in my PR to remove include_schedules, so it's still necessary. The fetch in departure.ex is called by multiple places, which is why that additional field is necessary
Contributor
Author
There was a problem hiding this comment.
I actually did catch one additional reference to Query.Opts that I removed in departures.ex, which is updated in this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asana task: Screens: Remove include_schedules configuration
include_scheduleshas been removed in screens codebaseinclude_schedulesoption has been removed from screen configs in dev, dev-green, and prodWith all that done, should be good to remove from here!