You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For these, since we've added both capeflyer as a possible pill type and ocean_blue as a possible color, we'd want to include selectors for both of those (similar to how the existing definitions have both --cr and --purple).
@digitalcora good call on including free_text changes here! Also added ferry selector to these files since it was missing, and bus for the pre_fare free_text since it was not currently included
Nice catch on the additional missing pill types — that's one less surprise waiting for us later.
And, apologies, but I did think of one other thing: To have the new capeflyer pill type actually work in FreeText, it needs to be added to components/v2/free_text.tsx in iconPills and iconPaths. For the SVG path it would use the same one as cr since it's the same icon. (The ocean_blue color should work as-is since this is put directly into a classname and not filtered to a list of known colors or anything.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asana task: Add CapeFlyer ocean blue color to FE
Adding this new color to the Frontend will allow Outfront to deploy this new code so that we can use it on the backend.