[NVIDIA] Removing hardcoded contributions and adding NVIDIA installation instructions#15
Draft
kvah wants to merge 54 commits intomc2-project:masterfrom
Draft
[NVIDIA] Removing hardcoded contributions and adding NVIDIA installation instructions#15kvah wants to merge 54 commits intomc2-project:masterfrom
kvah wants to merge 54 commits intomc2-project:masterfrom
Conversation
Merging enclave code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
12/23/20 PR Draft Update:
Includes updates from [PR #14], compatible with NVIDIA v3.1 Docker image
Updates
docker/README.mddockerPending Issues
kvahneed to be changed tosecure-aggregationto match with installation instructionsSome issues are potentially a result of changes made in
host.cppandecalls.cppthat include client contributions in the function headers (I might not be accessing the values in the enclave appropriately)