Skip to content

Opt out of CR.rrule if pullback is not defined #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Opt out of CR.rrule if pullback is not defined #130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/eval.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,15 +48,18 @@ import ChainRulesCore

function ChainRulesCore.rrule(ev::Eval, args...)
Z = ev.fwd(args...)
Z, function tullio_back(Δ)
isnothing(ev.rev) && error("no gradient definition here!")
function tullio_back(Δ)
dxs = map(ev.rev(Δ, Z, args...)) do dx
dx === nothing ? ChainRulesCore.ZeroTangent() : dx
end
tuple(ChainRulesCore.ZeroTangent(), dxs...)
return (ChainRulesCore.NoTangent(), dxs...)
end
return Z, tullio_back
end

# without gradient definition we let the AD system differentiate the function
ChainRulesCore.@opt_out ChainRulesCore.rrule(ev::Eval{<:Any,Nothing}, args...)

@init @require FillArrays = "1a297f60-69ca-5386-bcde-b61e274b549b" begin
using .FillArrays: Fill # used by Zygote
Tullio.promote_storage(::Type{T}, ::Type{F}) where {T, F<:Fill} = T
Expand Down