Conversation
|
It looks like this PR does fix the issues I was having with setting There does look to be some code for handling the new In my dive I also noticed alot of the pack merge code is missing max_format handling, but has handling for supported_formats. I'm not quite sure what happens to those fields under the current code and pack merging, but it may be worth taking a peek at, or at least being aware that it might be unsupported behavior. |
| assert a.overlay_parent is p | ||
|
|
||
| assert p == DataPack() | ||
| assert p != DataPack() |
There was a problem hiding this comment.
For this i feel like it's better to not have them equal, p is a datapack that has an overlay, and a new datapck instance doesn't.
| assert p != DataPack() | ||
| assert a == DataPack() | ||
| assert a == p | ||
| assert a != p |
There was a problem hiding this comment.
Same thing here a is a fresh datapack and p contains the overlay
|
For some strange reason this PR causes the Update: more likely, |
Yeah it wasn't working before, now the |
misode
left a comment
There was a problem hiding this comment.
This PR is working fine for Gamemode 4 now, we can probably merge this soon.
A try to format handeling, in the order what the pipeline does :