Skip to content

Changes so that library can be included locally from a src/ directory #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Changes so that library can be included locally from a src/ directory #476

wants to merge 5 commits into from

Conversation

jpmeijers
Copy link

Not necessary to merge this in, but rather be taken as an example of which changes I had to make to get #349 to work.

terrillmoore
terrillmoore requested changes Oct 21, 2019
View reviewed changes
Copy link
Member

@terrillmoore terrillmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can consider this merge, but we need to figure out how to make CI tests pass. Since all the other examples pass without this change, I wonder if the change to the example was intended?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrillmoore terrillmoore terrillmoore requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpmeijers @terrillmoore