Update SANS_Spheres to align with analytical validations. #2083
Conversation
Absorption was a factor of 100 larger than is postulated in the description and in the code. It used the wrong distance travelled for calculating the absorption
|
Hi @Lomholy thanks for yet another PR that will have to sit and wait while I am on vacation. One thing you might do in the meantime is to find / check the related test-instrument(s) and adapt the corresponding %Example value. (I believe the comp is used I at least one of the templateSANS oriented instruments.) Cheers |
Lomholy
left a comment
Lomholy
left a comment
There was a problem hiding this comment.
Hi Peter,
Oh yeah, sorry about that!
I found only one test that failed because of the changes, and this one was updated in the newest commit.
There were around 8 that used the component, but their %Examples were not all related to the scattering of the component.
Hope you enjoy your vacation!
Kind regards,
Daniel
|
@Lomholy I am now back from vacation. :) Thanks for the updated %Example value also. As a precaution and out of old habit I just ran the "test tools" on the modified branch for all the instruments including Sans_spheres (plus a couple of more in fact). It all checks out OK: Merging now. |
Absorption was a factor of 100 larger than is postulated in the description and in the code.
It used the wrong distance travelled for calculating the absorption.
Both of these things have been fixed. With this, it aligns with my analytical validation.