Create codeql.yml #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!--Delete sections as needed --> ## Description New IP setting for DD ## Related issues or tickets <!-- Related issues, pull requests, or Jira tickets --> ## Reviews <!-- Notes for reviewers here --> <!-- List applicable reviews (optionally @tag reviewers) --> - [ ] Technical review - [ ] Editorial review - [ ] Product review
## Description - Next DD release will support Enforce Sign-in for Teams, do not merge this until DD release date next week ## Related issues or tickets - https://docker.atlassian.net/browse/ENGDOCS-2669 ## Reviews - [ ] Editorial review
Docs for the new GUI for the MCP Toolkit. https://deploy-preview-22673--docsdocker.netlify.app/ai/mcp-catalog-and-toolkit/
<!--Delete sections as needed --> ## Description Add GUI docs for Docker Models. https://deploy-preview-22685--docsdocker.netlify.app/ai/model-runner/
Reverts the revert.
Desktop: rm experimental tab
Reduce magins, add hover effect, add light background 
<!--Delete sections as needed --> ## Description Redo docker#22773 ## Related issues or tickets <!-- Related issues, pull requests, or Jira tickets --> ## Reviews <!-- Notes for reviewers here --> <!-- List applicable reviews (optionally @tag reviewers) --> - [ ] Technical review - [ ] Editorial review - [ ] Product review
desktop: beta settings
## Description Replaced "Configure CI/CD" step of the Python guide with "Configure GitHub Actions" step to have it similar structure as the Rails guide. ## Related issues or tickets docker#22114 ## Reviews - [ ] Technical review - [x] Editorial review - [ ] Product review
…37.0 release-notes for Compose v2.37.0 version
…ocker#22794) ## Description This doc only listed 3 of the 4 images that Docker Desktop pulls when starting kind ## Related issues or tickets N/A ## Reviews <!-- Notes for reviewers here --> <!-- List applicable reviews (optionally @tag reviewers) --> cc @andrewb-ontheinternet @ctalledo - [X] Technical review - [ ] Editorial review - [ ] Product review
Add known issue for 4.42.0
redirect.yaml-fix
Unlikely used, but looks like this one was removed in de8fe08, so let's add it back. Signed-off-by: Sebastiaan van Stijn <[email protected]>
My IDE didn't like it being wrapped; probably didn't have an actual impact though, as browsers are quite forgiving. Signed-off-by: Sebastiaan van Stijn <[email protected]>
add one more missing redirect
<!--Delete sections as needed --> ## Description Parameter was missing. ## Related issues or tickets docker/buildx#3215 (comment) ## Reviews <!-- Notes for reviewers here --> <!-- List applicable reviews (optionally @tag reviewers) --> - [ ] Technical review - [ ] Editorial review - [ ] Product review
layouts: fix oddly formatted closing bracket
…ve-plan chore: remove plan from docs
…cker#22792) ## Description - Request from Product and Marketing, add blog post under "Learn more" heading for Settings Management guide ## Related issues or tickets https://docker.atlassian.net/browse/ENGDOCS-2697 ## Reviews - [ ] Technical review - [ ] Editorial review - [ ] Product review
desktop: ms store deploy
Fix typo: cif-volume → cifs-volume
…sions-update security: update roles and permissions
<!--Delete sections as needed --> ## Description Remove a couple of redundant steps in the MCP example for "Use Claude Desktop as a client". Bonus: remove some end-of-line whitespaces in the doc. ## Reviews <!-- Notes for reviewers here --> <!-- List applicable reviews (optionally @tag reviewers) --> - [ ] Technical review - [X] Editorial review - [ ] Product review Signed-off-by: Cesar Talledo <[email protected]> Co-authored-by: Arthur <[email protected]>
<!--Delete sections as needed --> ## Description As per https://docker.atlassian.net/browse/ENGDOCS-2836 Next up: - tidy up/ split the security FAQs - move the 'for developers' content up one level - beef up the Deploy DD page - AOB (didn't want to include in this PR as it's already too long) ## Reviews <!-- Notes for reviewers here --> <!-- List applicable reviews (optionally @tag reviewers) --> - [ ] Technical review - [ ] Editorial review - [ ] Product review
## Description - Fix conflict in published branch
Reverts docker#23091 to restore Enterprise doc changes
Update code fences that use a non-recognized codefence language value. Resolves docker#23081.
chore: add docker desktop 4.43.2 release notes
<!--Delete sections as needed -->
## Description
- Add "new" list repositories in a given namespace endpoint : `GET
/v2/namespaces/{namespace}/repositories`
---
After the comments from @thaJeztah
- Split DVP Data API and Docker Hub API for better visiblity
- Standardize sub entries in the side menu : Changelog, Deprecated and
OpenAPI
- Deprecated is now a table like in
https://docs.docker.com/engine/deprecated/
## Related issues or tickets
- docker/hub-feedback#2357
## Reviews
<!-- Notes for reviewers here -->
<!-- List applicable reviews (optionally @tag reviewers) -->
- [x] Technical review
- [ ] Editorial review
- [ ] Product review
Signed-off-by: CrazyMax <[email protected]>
ignore registry api links
PR that changes the deploy workflow of the docs. ## What has changed? This PR simplifies the deployment flow by deleting our staging build. We publish what is on the main branch instead of relying on the `publish` and `publish-update` branches.
run vale in docker
## Description Changed incorrect term used "container" -> "image" ## Reviews - [ ] Technical review - [x] Editorial review - [ ] Product review
## Description - Adds unassociated machines (AA) docs - Docs are unlisted ## Related issues or tickets https://docker.atlassian.net/browse/ENGDOCS-2855 ## Reviews - [ ] Editorial review - [ ] Product review @smnovick ## Preview link https://deploy-preview-23103--docsdocker.netlify.app/unassociated-machines/
Signed-off-by: Craig <[email protected]>
samples: fix link
Added a note to let users become aware of the OCI deletion endpoint. <!--Delete sections as needed --> ## Description <!-- Tell us what you did and why --> ## Related issues or tickets <!-- Related issues, pull requests, or Jira tickets --> ## Reviews <!-- Notes for reviewers here --> <!-- List applicable reviews (optionally @tag reviewers) --> - [ ] Technical review - [ ] Editorial review - [ ] Product review --------- Co-authored-by: Craig Osterhout <[email protected]>
<!--Delete sections as needed --> ## Description Part of https://docker.atlassian.net/browse/ENGDOCS-2836 ## Related issues or tickets <!-- Related issues, pull requests, or Jira tickets --> ## Reviews <!-- Notes for reviewers here --> <!-- List applicable reviews (optionally @tag reviewers) --> - [ ] Technical review - [ ] Editorial review - [ ] Product review
Fix wrong patch version to avoid confusion. ## Description Updated the patch version to avoid confusion for other developers. ## Reviews - [ ] Technical review - [ ] Editorial review
Co-authored-by: Jacob Howard <[email protected]> Co-authored-by: Allie Sadler <[email protected]>
## Description Shorten content, remove outdated screenshots.
<!--Delete sections as needed --> ## Description <!-- Tell us what you did and why --> ## Related issues or tickets <!-- Related issues, pull requests, or Jira tickets --> ## Reviews <!-- Notes for reviewers here --> <!-- List applicable reviews (optionally @tag reviewers) --> - [ ] Technical review - [ ] Editorial review - [ ] Product review
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| const a = document.createElement("a") | ||
| a.classList.add("underline","underline-offset-4","decoration-dashed","cursor-pointer") | ||
| a.title = `Learn more about the ${name} instruction` | ||
| a.href = `/reference/dockerfile/#${name.toLowerCase()}` |
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 5 months ago
To fix this issue, we should encode name before interpolating it into the URL fragment of the href attribute. The safest approach is to use encodeURIComponent, which encodes all characters that have special meaning in URLs (including #, ?, &, /, and spaces). This should be done directly on the value used in the href, i.e., change `/reference/dockerfile/#${name.toLowerCase()}` to `/reference/dockerfile/#${encodeURIComponent(name.toLowerCase())}`.
The change is limited to line 29 in assets/js/src/dockerfile-links.js. No additional imports are required, as encodeURIComponent is a global JavaScript function.
Suggested changeset
1
assets/js/src/dockerfile-links.js
| @@ -26,7 +26,7 @@ | ||
| const a = document.createElement("a") | ||
| a.classList.add("underline","underline-offset-4","decoration-dashed","cursor-pointer") | ||
| a.title = `Learn more about the ${name} instruction` | ||
| a.href = `/reference/dockerfile/#${name.toLowerCase()}` | ||
| a.href = `/reference/dockerfile/#${encodeURIComponent(name.toLowerCase())}` | ||
| a.innerHTML = cmd.outerHTML | ||
| cmd.insertAdjacentElement("beforebegin", a) | ||
| cmd.remove() |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues or tickets
Reviews