refactor: remove maintenance feature entirely

[mchestr]

Summary

This PR removes the entire maintenance feature from the codebase, including:

• All maintenance admin pages (rules, candidates, history, user-feedback)
• All maintenance UI components (rule builder, candidate list, condition inputs, etc.)
• All maintenance backend code (scanner, evaluator, deleter, field registry, services)
• All maintenance actions, validations, and API routes
• Database migration to drop related tables

Motivation

The maintenance feature had broken task scheduling architecture that needs to be rethought. Rather than maintaining complex code that isn't working correctly, this removes it entirely to simplify the codebase.

Preserved Functionality

• User media marks - The ability for users to mark media (via Discord bot) remains functional
• actions/user-marks.ts - Moved from actions/maintenance/user-marks.ts
• lib/validations/user-media.ts - Extracted only the needed schemas
• Discord bot integration continues to work for marking media as finished

Database Changes

Migration 20251206172926_remove_maintenance_tables drops:

• MaintenanceRule table
• MaintenanceScan table
• MaintenanceCandidate table
• MaintenanceDeletionLog table
• ScanStatus, ReviewStatus, ActionType enums

Impact

• 90 files changed: 103 insertions, 24,380 deletions
• Significantly reduces codebase complexity
• Removes all BullMQ/Redis dependencies (from previous commit)

Test Plan

• Removed all maintenance-related tests
• Verified user-marks functionality preserved
• Admin navigation updated correctly
• Build passes
• Remaining tests pass
• Database migration applies cleanly

🤖 Generated with Claude Code

[claude]

Code Review - PR #204: Remove Maintenance Feature

Summary

This PR removes ~24,000 lines of maintenance-related code (90 files) including rules, candidates, scanning, and deletion history. The scope is massive but the approach is clean - a complete feature removal rather than partial deprecation.

Critical Issues Found

🔴 1. Orphaned Test File (Must Fix)

• File: e2e/admin-maintenance.spec.ts (485 lines)
• Issue: Complete E2E test suite for maintenance feature still exists
• Impact: Tests will fail immediately - references non-existent pages, components, and database tables
• Location: Lines 1-485 reference deleted routes like /admin/maintenance/rules, /admin/maintenance/candidates
• Fix Required: Delete this file

🔴 2. Orphaned Helper File (Must Fix)

• File: e2e/helpers/maintenance-seed.ts
• Issue: Seed data helper for maintenance tests still exists
• Impact: Unused code, imports non-existent Prisma models
• Fix Required: Delete this file

🔴 3. Broken Re-export File (Must Fix)

• File: actions/maintenance.ts
• Issue: Still tries to re-export from deleted ./maintenance/index
• Current Code:

  export * from "./maintenance/index"

• Impact: Build will fail with module not found error
• Fix Required: Delete this file entirely

Issues Identified

Database Migration (✅ Looks Good)

• File: prisma/migrations/20251206172926_remove_maintenance_tables/migration.sql
• Properly drops all 4 tables: MaintenanceRule, MaintenanceScan, MaintenanceCandidate, MaintenanceDeletionLog
• Correctly removes 3 enums: ActionType, ReviewStatus, ScanStatus
• Properly drops foreign key constraints before tables
• ⚠️ Note: Adds HELP value to DiscordCommandType enum - seems unrelated to this PR, but acceptable

Preserved Functionality (✅ Looks Good)

• User Media Marks: Correctly preserved in actions/user-marks.ts
• Validations: Clean extraction to lib/validations/user-media.ts with only necessary schemas
• Admin Nav: Properly updated, removed maintenance section entirely

Positive Observations

1. Clean Extraction: User marks functionality cleanly separated from maintenance code
2. Complete Removal: No half-measures - entire feature removed rather than leaving dead code
3. Schema Update: Prisma schema properly cleaned (no maintenance table references found)
4. Migration Safety: Migration includes proper warnings about data loss

Recommendations

Must Fix Before Merge

1. Delete e2e/admin-maintenance.spec.ts
2. Delete e2e/helpers/maintenance-seed.ts
3. Delete actions/maintenance.ts

Build Verification Needed

• Cannot verify build locally (dependencies not installed)
• The PR checklist shows build/tests as incomplete
• Critical: These 3 orphaned files will cause build failures

Test Coverage

• Verify user marks functionality still works after removal
• Test Discord bot media marking integration (claimed to be preserved)

Security & Performance

• ✅ No security concerns - removing code reduces attack surface
• ✅ No sensitive data exposed in migration
• ✅ Performance improvement - removing unused tables and code

Code Quality

• ✅ Follows project conventions (Server Actions, Zod validation in preserved code)
• ✅ No backwards-compatibility hacks left behind
• ❌ Incomplete cleanup - 3 files missed

Final Verdict

Cannot approve until orphaned files are removed. The concept is sound and the migration is clean, but the PR is incomplete. The 3 remaining files will cause immediate build failures.

Suggested Next Steps

1. Remove the 3 orphaned files listed above
2. Run npm run build to verify no import errors
3. Run npm test to ensure no test failures
4. Update PR checklist to mark build/tests as passing

---

📋 Reviewed by Claude Code following CLAUDE.md guidelines

[claude]

Code Review - PR #204: Remove Maintenance Feature

I've reviewed this PR which removes the entire maintenance feature from the codebase. Overall, this is a massive cleanup (26,027 deletions!) that simplifies the codebase significantly. However, there are several issues that need to be addressed before merging.

---

🐛 Issues Found

1. CRITICAL: Failing Test References ❌

The test file components/__tests__/admin-shared.test.tsx still contains references to removed maintenance pages:

Lines 321, 408, 564-566, 678, 784:

• References to admin-nav-maintenance-overview-mobile
• References to admin-nav-maintenance-rules-mobile
• References to admin-nav-maintenance-candidates-mobile
• Line 408 expects 3 section headers including "Library Maintenance"

Impact: These tests will fail when run, breaking the CI pipeline.

Fix Required: Update or remove these test assertions to match the new navigation structure without maintenance sections.

---

2. Outdated API Route Comments ⚠️

Files:

• app/api/admin/radarr/route.ts:12
• app/api/admin/sonarr/route.ts:12

Both files have comments mentioning maintenance features:

* (e.g., for dropdowns/selectors in maintenance rule creation).

Impact: Low - just stale documentation in comments

Fix Required: Update these comments to remove maintenance references, or provide updated examples.

---

3. Migration-Only Database Schema 🔍

The database migration properly drops all maintenance tables and enums. However, I notice the migration also adds a new enum value:

ALTER TYPE "DiscordCommandType" ADD VALUE 'HELP';

Question: Is this HELP command type intentional as part of this PR, or should it be in a separate migration? The PR description doesn't mention Discord command changes.

Recommendation: If unrelated, consider splitting into a separate migration for cleaner git history.

---

✅ Strengths

Well-Executed Removal

• Complete cleanup: All 90 files properly removed including components, actions, validations, tests, E2E tests, and documentation
• Preserved functionality: User media marks correctly extracted and preserved in actions/user-marks.ts
• Clean migration: Database migration properly drops tables with foreign key constraints in correct order
• Updated IMPROVEMENTS.md: Properly documented that issues Fix excessive 'as any' type casts bypassing type safety #29-45 are now obsolete

Code Quality

• Navigation updated correctly: Admin nav properly refactored to remove maintenance links (desktop view looks good)
• Validation schemas: New lib/validations/user-media.ts properly extracts only needed schemas with correct Zod validation
• Import updates: actions/user-marks.ts correctly updated to import from new validation file location

Architecture

• Simplified codebase: Removing 26K lines of complex, non-functional code is the right call
• Clear boundaries: User marking feature cleanly separated from maintenance system

---

🔒 Security Considerations

✅ No new security concerns introduced

• Server actions still have proper auth checks (getServerSession)
• Input validation with Zod schemas maintained
• Database operations use Prisma (no SQL injection risk)

---

🏎️ Performance Considerations

✅ Positive impact

• Removing unused database tables reduces schema complexity
• Fewer indexes to maintain
• Smaller bundle size (removed components won't be included in build)

---

🧪 Test Coverage

⚠️ Needs attention

• All maintenance-related tests properly removed ✅
• BUT: Admin navigation tests need updates (see Issue chore(deps): bump actions/setup-node from 4 to 6 #1 above)
• User marks tests preserved in correct location ✅

---

📋 Recommendations

Before Merging:

1. Fix failing test in components/__tests__/admin-shared.test.tsx

   • Remove assertions expecting maintenance nav items
   • Update section header count from 3 to 2

2. Update API route comments to remove maintenance references

3. Verify the build passes:

   npm run build

4. Run tests to confirm:

   npm test

5. Clarify Discord HELP command: Is this intentional in this PR?

---

📝 PR Checklist Review

From your test plan:

• ✅ Removed all maintenance-related tests
• ✅ Verified user-marks functionality preserved
• ✅ Admin navigation updated correctly (desktop)
• ❌ Build passes - needs verification (dependencies not installed in review env)
• ❌ Remaining tests pass - navigation tests will fail (Issue chore(deps): bump actions/setup-node from 4 to 6 #1)
• ⚠️ Database migration applies cleanly - looks good but needs testing in real environment

---

🎯 Verdict

Conditional Approval - This is excellent cleanup work, but please address the test failures before merging. The changes are architecturally sound and the removal is complete, but the broken tests will block CI.

Estimated fix time: ~15-30 minutes to update the navigation tests.

Great job on this massive refactoring! The codebase will be much cleaner once these final issues are resolved.

---

🤖 Generated with Claude Code

[claude]

PR Review - Maintenance Feature Removal

I've completed a comprehensive review of this PR. Overall, this is a well-executed large-scale refactoring that successfully removes a complex feature while preserving necessary functionality.

✅ Strengths

1. Clear Scope & Motivation

   • Well-documented PR description explaining the rationale
   • Appropriate decision to remove broken functionality rather than maintaining dead code
   • 26,046 deletions vs 124 additions shows genuine simplification

2. Preserved User Functionality

   • User media marks correctly extracted to actions/user-marks.ts
   • New validation file lib/validations/user-media.ts contains only needed schemas
   • Discord bot integration remains functional

3. Clean Database Migration

   • Migration properly drops all 4 tables (MaintenanceRule, MaintenanceScan, MaintenanceCandidate, MaintenanceDeletionLog)
   • Correctly drops 3 enums (ActionType, ReviewStatus, ScanStatus)
   • Adds HELP enum value to DiscordCommandType (unrelated enhancement)

4. Updated Tests

   • Fixed admin-shared.test.tsx to match new navigation (2 section dividers instead of 3, 7 More menu items)
   • Removed all maintenance-related test files
   • Tests now accurately reflect the simplified navigation structure

5. Navigation Cleanup

   • admin-nav.tsx properly removes maintenance section while maintaining clean organization
   • API route comments updated to remove maintenance references

⚠️ Issues Found

1. Outdated Documentation References (Medium Priority)

Several documentation files still reference the removed maintenance feature:

docs/performance-testing.md

• Multiple references to scripts/performance/profile-maintenance-query.ts (deleted)
• Instructions for profiling maintenance queries
• References to actions/maintenance/rules.ts (deleted)
• Recommendation: Either remove this entire file or rewrite it for other performance testing scenarios

CLAUDE.md (lines 333-356)

• JSDoc examples reference lib/maintenance/rule-evaluator.ts (deleted)
• References to lib/maintenance/__tests__/jsdoc-examples.test.ts (deleted)
• Recommendation: Update to use a different example module or remove this section

IMPROVEMENTS.md (line 88)

• Task references MaintenanceCandidate type and types/maintenance.ts (both deleted)
• Recommendation: Remove this stale task item

2. Minor Documentation Issues (Low Priority)

docs/discord-bot.md (line 46)

• Generic mention of "maintenance" in context of disabling bot (this is fine, just noting for completeness)

.claude/commands/update-pr.md

• Reference to "test maintenance" workflows (also fine, generic usage)

📋 Recommendations

Required Before Merge:

1. Update docs/performance-testing.md

   • Remove entire file OR rewrite to document other performance testing scenarios
   • The current content is 100% about the deleted maintenance feature

2. Update CLAUDE.md

   • Find a different module to use as the JSDoc documentation example
   • Or remove the specific references to maintenance modules

3. Clean up IMPROVEMENTS.md

   • Remove the stale task on line 88 that references deleted types

Suggested (Nice to Have):

4. Verify Build & Tests Pass
   • I attempted to run the build but encountered Prisma issues in the review environment
   • Ensure CI passes before merging
   • The PR description checklist shows builds/tests pending

🔒 Security & Best Practices

✅ No security concerns identified

• Properly uses Prisma for all database operations
• Server Actions maintain auth checks
• No SQL injection risks
• Migration is safe (uses DROP TABLE/ENUM)

✅ Follows project conventions

• TypeScript strict mode compliance
• Proper use of Zod validation
• Server Actions follow established patterns
• Component tests properly updated

📊 Impact Assessment

Positive:

• Removes ~24,000 lines of broken/unused code
• Simplifies codebase significantly
• Reduces maintenance burden
• Cleaner admin navigation

Negative:

• Loss of maintenance rule functionality (but was broken anyway)
• Documentation cleanup needed (items listed above)

Risk Level: ✅ Low - This is a clean removal with no obvious regressions

🎯 Final Verdict

Approve with minor changes required - Fix the documentation references before merge, then this is good to go.

The core refactoring is solid, tests are updated correctly, and the migration is safe. The only issues are stale documentation references that should be cleaned up to avoid future confusion.

---

Code Quality: ⭐⭐⭐⭐⭐ Excellent
Testing: ⭐⭐⭐⭐⭐ Comprehensive
Documentation: ⭐⭐⭐☆☆ Needs updates
Overall: ⭐⭐⭐⭐☆ Strong PR, minor cleanup needed