Sanitize shell interpolations to prevent injection#75
Open
zmanian wants to merge 1 commit intomcintyre94:mainfrom
Open
Sanitize shell interpolations to prevent injection#75zmanian wants to merge 1 commit intomcintyre94:mainfrom
zmanian wants to merge 1 commit intomcintyre94:mainfrom
Conversation
Add a shellEscape() helper for safe single-quote wrapping and apply it to all shell command construction sites: - ChatViewModel: workingDirectory, tokens, sessionId, MCP config - SpriteOverviewViewModel: GitHub and Sprites CLI token auth - ClaudeQuestionTool: validate sessionId chars in file paths/JSON Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shellEscape()utility that wraps values in single quotes with proper escapingChatViewModel(workingDirectory, tokens, sessionId, MCP config paths, prompts, git name/email, custom instructions)SpriteOverviewViewModel(GitHub token auth, Sprites CLI token auth)sanitizedSessionId()toClaudeQuestionToolthat strips non-alphanumeric characters from sessionId before using it in file paths and JSONPreviously,
workingDirectory,sessionId,configPath, and tokens were interpolated directly into shell commands without escaping. While exploitation risk is low (values come from controlled sources), defense-in-depth is warranted for shell command construction.Test plan
Generated with Claude Code