Replace force-unwrapped URL construction with safe guards#76
Open
zmanian wants to merge 1 commit intomcintyre94:mainfrom
Open
Replace force-unwrapped URL construction with safe guards#76zmanian wants to merge 1 commit intomcintyre94:mainfrom
zmanian wants to merge 1 commit intomcintyre94:mainfrom
Conversation
Convert URL(string:)! and URLComponents(string:)! to guarded unwraps that throw AppError.invalidURL or use preconditionFailure for URLs built from known-safe components. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
components.url!increateExecSessionandattachExecSessiontoguard letwithpreconditionFailure(these URLs are built from known-good components, so nil is theoretically impossible, but we should still guard)URLComponents(string:)!infileExistsanduploadFiletoguard varthat throwsAppError.invalidURL(these use user-providedspriteNamewhich could theoretically produce invalid URLs)URL(string:)!inGitHubAPIClienttoguard letwithURLError(.badURL)for consistencyTest plan
Generated with Claude Code